Skip to content

Comments

updated YZ maps#900

Merged
nathanielerowe merged 3 commits intodevelopfrom
yz_map_update_fall25
Feb 2, 2026
Merged

updated YZ maps#900
nathanielerowe merged 3 commits intodevelopfrom
yz_map_update_fall25

Conversation

@sxy1439
Copy link
Contributor

@sxy1439 sxy1439 commented Jan 20, 2026

Description

Please provide a detailed description of the changes this pull request introduces.

This is a PR to update YZ non-uniformity map using the gen2 samples. Below are the samples used to generate maps for this PR -

[Data] data_MCP2025C_Fall25-Run1_BNB_Dev_bnblight_v10_14_02_histreco2_sbnd
[MC] mc_MCP2025C_FallProduction_prodgenie_corsika_proton_rockbox0p1_sbnd_CV_v10_14_02_histreco2_sbnd

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{red}\bf{\textrm{IMPORTANT UPDATE June 22nd 2025:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production (which started in Spring 2025), you must make two PRs: one for develop and one for the production/v10_06_00 branch.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer. No
  • Does this affect the standard workflow? No
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

@sxy1439 sxy1439 requested review from linyan-w and mrmooney January 20, 2026 18:42
@sxy1439 sxy1439 self-assigned this Jan 20, 2026
@sxy1439 sxy1439 added the reco1/reco2 Reconstruction label Jan 20, 2026
@nathanielerowe
Copy link
Contributor

nathanielerowe commented Jan 20, 2026

Should this be accompanied by an sbnd_data PR? We have switched to using github for those: https://github.com/SBNSoftware/sbnd_data

@linyan-w linyan-w moved this to Waiting on Reviewer in SBND 2025 Fall Production Jan 20, 2026
@linyan-w linyan-w requested a review from tbwester January 20, 2026 19:51
@sxy1439 sxy1439 mentioned this pull request Jan 21, 2026
Merged
@sxy1439
Copy link
Contributor Author

sxy1439 commented Jan 21, 2026

Yes! I made an sbnd_data PR #9 (SBNSoftware/sbnd_data#9) that should go with this PR. Thanks Nate for updating me with the recent changes.

@nathanielerowe nathanielerowe moved this from Waiting on Reviewer to Reviewer Approved in SBND 2025 Fall Production Jan 23, 2026
@nathanielerowe nathanielerowe moved this from Reviewer Approved to Waiting on Reviewer in SBND 2025 Fall Production Jan 23, 2026
@nathanielerowe
Copy link
Contributor

nathanielerowe commented Jan 23, 2026

waiting on final reviewer approval until after calibration meeting presentation next week

linyan-w
linyan-w approved these changes Jan 29, 2026
View reviewed changes
Copy link
Contributor

@linyan-w linyan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on this presentation.
https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=45421

@nathanielerowe
Copy link
Contributor

nathanielerowe commented Jan 29, 2026

trigger build ci_ref=v10_14_02_01 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_01 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_01

@FNALbuild
Copy link
Collaborator

FNALbuild commented Jan 29, 2026

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Jan 29, 2026

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Jan 29, 2026

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Jan 29, 2026

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Contributor

nathanielerowe commented Feb 2, 2026

Approved

@nathanielerowe nathanielerowe merged commit 369ab65 into develop Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbwester tbwester tbwester approved these changes

@linyan-w linyan-w linyan-w approved these changes

@mrmooney mrmooney Awaiting requested review from mrmooney

Assignees

@sxy1439 sxy1439

Labels

reco1/reco2 Reconstruction

Projects

SBND 2025 Fall Production
Status: Waiting on Reviewer

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sxy1439 @nathanielerowe @FNALbuild @tbwester @linyan-w